-
Notifications
You must be signed in to change notification settings - Fork 242
Mount actual latest semantic version at /docs/k6/latest/ #2038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
d326678
to
1f7f64e
Compare
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
1f7f64e
to
086196e
Compare
"relative_prefix": "/docs/k6/latest", | ||
"repo": "k6-docs", | ||
"source_directory": "docs/sources/k6/next", | ||
"source_directory": "docs/sources/k6/<LATEST>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the impact of this change? I can't tell just by looking at the change itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see "TESTING AGAIN" in the previews... i think that this wouldn't show up if it was pointing to next
? When we change something in next
and not in the "latest
" directory, is it possible to preview that too?
I'm confused as to if I should review this ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for updating the deploy preview for this repo @jdbaldry. 🙇
Apologies reviewers for the poor PR description, it assumed the context from the previous PR. I've updated it now and things should make more sense. |
The introduction of this workflow in #2014 mounted the "next" documentation at the
/docs/k6/latest/
location and @heitortsergent pointed out that this could confuse people.This version of the workflow mounts the latest version semantic-version-like directory at that location instead for an experience that matches the website behavior.
The behavior was implemented in grafana/writers-toolkit#1217.
I'll drop the CI triggering test commit before merge
Signed-off-by: Jack Baldry jack.baldry@grafana.com