Skip to content

Conversation

jdbaldry
Copy link
Contributor

@jdbaldry jdbaldry commented Aug 18, 2025

The introduction of this workflow in #2014 mounted the "next" documentation at the /docs/k6/latest/ location and @heitortsergent pointed out that this could confuse people.

This version of the workflow mounts the latest version semantic-version-like directory at that location instead for an experience that matches the website behavior.

The behavior was implemented in grafana/writers-toolkit#1217.

I'll drop the CI triggering test commit before merge

Signed-off-by: Jack Baldry jack.baldry@grafana.com

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry force-pushed the jdb/2025-08-deploy-preview-latest branch from d326678 to 1f7f64e Compare August 18, 2025 09:41
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry force-pushed the jdb/2025-08-deploy-preview-latest branch from 1f7f64e to 086196e Compare August 18, 2025 09:44
@jdbaldry jdbaldry changed the title Mount latest docs correctly Mount actual latest semantic version at /docs/k6/latest/ Aug 18, 2025
Copy link
Contributor

github-actions bot commented Aug 18, 2025

@jdbaldry jdbaldry marked this pull request as ready for review August 18, 2025 09:52
@jdbaldry jdbaldry requested review from heitortsergent and a team as code owners August 18, 2025 09:52
@jdbaldry jdbaldry requested review from oleiade and ankur22 and removed request for a team August 18, 2025 09:52
"relative_prefix": "/docs/k6/latest",
"repo": "k6-docs",
"source_directory": "docs/sources/k6/next",
"source_directory": "docs/sources/k6/<LATEST>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the impact of this change? I can't tell just by looking at the change itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see "TESTING AGAIN" in the previews... i think that this wouldn't show up if it was pointing to next? When we change something in next and not in the "latest" directory, is it possible to preview that too?

@oleiade
Copy link
Contributor

oleiade commented Aug 21, 2025

I'm confused as to if I should review this (TESTING AGAIN), and why 😄
I'll respectfully dismiss myself from this review 🙇🏻

@oleiade oleiade removed their request for review August 21, 2025 07:03
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for updating the deploy preview for this repo @jdbaldry. 🙇

@jdbaldry
Copy link
Contributor Author

Apologies reviewers for the poor PR description, it assumed the context from the previous PR. I've updated it now and things should make more sense.

@jdbaldry jdbaldry merged commit 4b5e497 into main Aug 26, 2025
2 checks passed
@jdbaldry jdbaldry deleted the jdb/2025-08-deploy-preview-latest branch August 26, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants