Skip to content

Conversation

heitortsergent
Copy link
Collaborator

@heitortsergent heitortsergent commented Sep 2, 2025

What?

Style guide and Vale fixes to the k6 Browser JavaScript API getBy pages.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

#2023

@heitortsergent heitortsergent marked this pull request as ready for review September 2, 2025 20:08
@heitortsergent heitortsergent requested a review from a team as a code owner September 2, 2025 20:08
@heitortsergent heitortsergent requested review from oleiade and removed request for a team September 2, 2025 20:08
@heitortsergent
Copy link
Collaborator Author

@ankur22 I made some small edits to the getBy PR from last month (I'm trying to review some stuff that I missed in the past few weeks).

Let me know what you think, they are mostly style guide/Vale fixes, no big changes to the content.

@heitortsergent heitortsergent removed the request for review from oleiade September 2, 2025 20:09
@heitortsergent heitortsergent self-assigned this Sep 2, 2025
@heitortsergent heitortsergent added the Area: browser The browser module label Sep 2, 2025
Copy link
Contributor

github-actions bot commented Sep 2, 2025

💻 Deploy preview deleted.

Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for this!

@heitortsergent heitortsergent merged commit b03f9b4 into main Sep 3, 2025
9 checks passed
@heitortsergent heitortsergent deleted the hts/browser-getBy branch September 3, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: browser The browser module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants