Browser: Add getBy* APIs for frame, frameLocator and locator docs and locator.contentFrame #2055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview deleted. |
AgnesToulet
requested review from
inancgumus and
codebien
and removed request for
a team
AgnesToulet
changed the title
ankur22
approved these changes
Sep 19, 2025
codebien
approved these changes
Sep 19, 2025
|
|
||
| # getByTestId(testId) | ||
|
|
||
| Returns a locator for elements with the specified test ID attribute. This method is designed for robust test automation by locating elements using dedicated test identifiers that are independent of the visual appearance or content changes. Currently it can only work with the `data-testid` attribute. |
There was a problem hiding this comment.
@AgnesToulet in general we try to avoid using "currently" in the docs, and we focus on documenting the current behavior. Do you know if this is something that would change soon?
There was a problem hiding this comment.
No plans to change it, should I just remove currently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR includes:
getBy*APIs forframeLocator,frameandlocator(main doc was taken from thepageclass and moved to thesharedfolder)locator.contentFrame()APIpage.getBy*methods (you can see them in this commit as they are hard to see with the move to the shared folder)Checklist
I have used a meaningful title for the PR.
I have described the changes I've made in the "What?" section above.
I have performed a self-review of my changes.
I have run the
npm startcommand locally and verified that the changes look good.I have made my changes in the
docs/sources/k6/nextfolder of the documentation.Related PR(s)/Issue(s)