update xk6-browser code examples to async/await #996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a version of the docs published here: https://mdr-ci.staging.k6.io/docs/refs/pull/996/merge It will be deleted automatically in 30 days. |
inancgumus
approved these changes
Jan 24, 2023
ankur22
reviewed
Jan 24, 2023
src/data/markdown/docs/30 xk6-browser/01 Get started/01 Welcome.md
Outdated
Show resolved
Hide resolved
ankur22
requested changes
Jan 24, 2023
mdcruz
force-pushed
the
update-xk6-browser-docs
branch
from
f3db542 to
a4fd4b9
Compare
mdcruz
force-pushed
the
update-xk6-browser-docs
branch
from
4ed1018 to
98aeb88
Compare
mdcruz
force-pushed
the
update-xk6-browser-docs
branch
from
0d8d5f5 to
ba32672
Compare
mdcruz
force-pushed
the
update-xk6-browser-docs
branch
from
ba32672 to
0ea0174
Compare
mdcruz
changed the title
mdcruz
commented
Feb 9, 2023
src/data/markdown/docs/30 k6-browser/01 Get started/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
ka3de
reviewed
Feb 9, 2023
There was a problem hiding this comment.
Awesome @mdcruz ! 🥇
I added a couple of small comments.
Besides the content, I personally like the change from xk6-browser naming to k6 browser, but, as mentioned, I will not enter in discussing organization matters in terms of where should these docs be placed etc as I believe I'm not the best person to do that.
src/data/markdown/docs/30 k6-browser/01 Get started/02 Running browser tests.md
Outdated
Show resolved
Hide resolved
src/data/markdown/docs/30 k6-browser/02 API/08 Locator/textcontent--options--.md
Outdated
Show resolved
Hide resolved
inancgumus
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Nice work 👏
I have one suggestion and this comment about Docker.
src/data/markdown/docs/30 k6-browser/02 API/02 BrowserContext/setDefaultTimeout.md
Outdated
Show resolved
Hide resolved
…setDefaultTimeout.md Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
|
@mdcruz k6 v0.43.0 was just released, and v0.42.0 docs have been archived. Can we merge this PR? |
ankur22
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following changes for the xk6-browser documentation, which needs to be merged after v.0.43.0 release