Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade xk6-dashboard to v0.7.5 #3821

Merged
merged 1 commit into from
Jul 2, 2024
Merged

feat: upgrade xk6-dashboard to v0.7.5 #3821

merged 1 commit into from
Jul 2, 2024

Conversation

szkiba
Copy link
Contributor

@szkiba szkiba commented Jul 1, 2024

What?

Upgrade xk6-dashboard to v0.7.5

Why?

Configuration customization from JavaScript code has been removed

Until now, the dashboard configuration could be customized with a JavaScript code. Supporting this feature after switching the JavaScript interpreter (goja to sobek) causes serious difficulties. Since this feature is rarely used, it is easier to drop it than to support it.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

@szkiba szkiba requested a review from a team as a code owner July 1, 2024 19:05
@szkiba szkiba requested review from mstoykov and joanlopez and removed request for a team July 1, 2024 19:05
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.94%. Comparing base (c682fa2) to head (226bff7).

Current head 226bff7 differs from pull request most recent head ce3b963

Please upload reports for the commit ce3b963 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3821   +/-   ##
=======================================
  Coverage   71.93%   71.94%           
=======================================
  Files         291      291           
  Lines       21277    21277           
=======================================
+ Hits        15305    15307    +2     
+ Misses       4913     4912    -1     
+ Partials     1059     1058    -1     
Flag Coverage Δ
ubuntu 71.87% <ø> (+<0.01%) ⬆️
windows 71.78% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szkiba szkiba merged commit bf218a9 into master Jul 2, 2024
22 checks passed
@szkiba szkiba deleted the dashboard-v0.7.5 branch July 2, 2024 04:05
@mstoykov mstoykov added this to the v0.53.0 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants