Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend using the globally available timers #3847

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Recommend using the globally available timers #3847

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
270427c
Recommend using the globally available timers
mstoykov Jul 15, 2024
d4d0874
Apply suggestions from code review
mstoykov Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions js/jsmodules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ func getInternalJSModules() map[string]interface{} {
"k6/experimental/webcrypto": webcrypto.New(),
"k6/experimental/websockets": &expws.RootModule{},
"k6/experimental/timers": newWarnExperimentalModule(timers.New(),
"Please update your imports to use k6/timers instead of k6/experimental/timers,"+
" which will be removed after September 23rd, 2024 (v0.54.0). Ensure your scripts are migrated by then."+
" There are no API changes, so this is a drop in replacement."),
"The exports of `k6/experimental/timers` as globally available, so no need to import them."+
mstoykov marked this conversation as resolved.
Show resolved Hide resolved
" The emodule will be removed after September 23rd, 2024 (v0.54.0). Ensure your scripts are migrated by then."+
mstoykov marked this conversation as resolved.
Show resolved Hide resolved
" There are no API changes, so this is a drop in replacement and is also available under `k6/timers`."),
mstoykov marked this conversation as resolved.
Show resolved Hide resolved
"k6/experimental/tracing": tracing.New(),
"k6/experimental/browser": newWarnExperimentalModule(browser.NewSync(),
"Please update your imports to use k6/browser instead of k6/experimental/browser,"+
Expand Down