Implement import.meta.resolve() #3873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements and tests `import.meta.resolve()` a way to get the path to a module the same way ESM and/or `require` will do. This doesn't read or load the file in question from the file. This also showed that we currently always parse code as ECMAScript modules. Even when the parsed/compiled file was to be wrapped as CommonJS. This likely had no other side effects as all other ESM specific syntax is also either not implemented in k6 or forces CommonJS wrapping disabled. Closes #3856
mstoykov
added
feature
documentation-needed
mstoykov
requested review from
codebien and
joanlopez
and removed request for
a team
codebien
previously approved these changes
Jul 30, 2024
joanlopez
reviewed
Jul 30, 2024
js/bundle.go
Outdated
| @@ -451,6 +451,16 @@ func (b *Bundle) setInitGlobals(rt *sobek.Runtime, vu *moduleVUImpl, modSys *mod | |||
| } | |||
| warnAboutModuleMixing("module") | |||
| warnAboutModuleMixing("exports") | |||
|
|
|||
| rt.SetFinalImportMeta(func(o *sobek.Object, mr sobek.ModuleRecord) { | |||
| _ = o.Set("resolve", func(specifier string) (string, error) { | |||
There was a problem hiding this comment.
Shouldn't we do something with the error in case there's any? If it isn't supposed to happen, at all, I'm generally in favor of panicking.
joanlopez
reviewed
Jul 30, 2024
joanlopez
previously approved these changes
Jul 30, 2024
Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com>
joanlopez
approved these changes
Jul 30, 2024
codebien
approved these changes
Jul 30, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This implements and tests
import.meta.resolve()a way to get the path to a module the same way ESM and/orrequirewill do.This doesn't read or load the file in question from the file.
This also showed that we currently always parse code as ECMAScript modules. Even when the parsed/compiled file was to be wrapped as CommonJS.
This likely had no other side effects as all other ESM specific syntax is also either not implemented in k6 or forces CommonJS wrapping disabled.
Why?
This lets people use
open,require,experimental/fs.open, etc. and have a way to always be relative to the module it is written in.The fixes to compiler were as otherwise CommonJS modules don't error on
import.metaand doesn't just isn't supported in the standard.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
#3856