Loki Helm Chart: Add missing server config ingester_client

[andersondario]

What this PR does / why we need it: It adds a missing server configuration option in Helm chart, as described here in the docs: Supported contents and default values of loki.yaml

Which issue(s) this PR fixes:
#6182

Special notes for your reviewer:

Checklist

• Reviewed the CONTRIBUTING.md guide (required)
• Documentation added
• Tests updated
• CHANGELOG.md updated
  • If the change is worth mentioning in the release notes, add add-to-release-notes label
• Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
• For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
• If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

[CLAassistant]

All committers have signed the CLA.

[MichelHollands]

@andersondario What is your use case here? This setting doesn't seem needed in SSD mode so I'm not sure how this would fix anything. Also you don't specify a default value.

[niklas-gullberg-ing]

This would help #6182 where the suggested workaround is to increase ingester_client.remote_timeout, since the config is currently unavailable through helm.

[andersondario]

@andersondario What is your use case here? This setting doesn't seem needed in SSD mode so I'm not sure how this would fix anything. Also you don't specify a default value.

I had to do a workaround a few months ago when I installed Loki in a Kubernetes cluster on GCP. I don't remember in detail what the problem was, but I think it was related to the issue #6182 as @niklas-gullberg-ing mentioned

#6182 (comment)

[ivanfavi]

@coro Is there anything we can do to get this PR merged?

[coro]

I'm afraid I'm not a maintainer of this repo, but @DylanGuedes & @JStickler may be able to help! I believe there is also a Community Call weekly where you may be able to ask for help from the community.

[ivanfavi]

@MichelHollands Could you please assist in merging this PR? Is there anything missing?

[DylanGuedes]

In case this is blocking any of you: you can use the other Helm config sections to accomplish the same. You can add a ingester_client to your own structuredConfig section and it will work similar to this one.

[ivanfavi]

@DylanGuedes Using structuredConfig would completely override the templated value of loki.config. In our case, we prefer to continue using the templated approach for Loki configuration.

This pull request appears to be a straightforward addition to the Helm chart. Could you let us know if there's anything incorrect or missing in our proposed changes? We're keen to understand why it might not be suitable for merging.

[alex-berger]

Having the same need, so would love to see this PR merged.

[CmdrSharp]

I too would appreciate this to be merged. It seems like a very minor, non-breaking change. What's holding it up?

[trevorwhitney]

sorry this has been sitting for so long. I'm good to get it merged. Can you remove the manual update of the version, and add a changleog entry?