-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the lokitool docs #12805
Conversation
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands , @monodot and I were just looking at this section in the docs when we were working together today, and I realized that while we tell users how to use cortex tool (now loki tool) we don't tell them how to get the tool. I assume that once Loki tool released, there would be a download link somewhere that we'd need to include? Also, I was surprised to find out that the cortex tool help seems to be in the repo README. Does the loki tool include any |
Hey, the distribution of lokitool is not done yet. The plan is to add that this week. It wasn't done for 3.0 yet as too many other things were going on. Lokitool does respond to --help:
|
Awesome! Thanks for providing the output! I had checked the PR dates and knew that it hadn't made it into the last release. But it will be nice to have some documentation ready to go with the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] Looks good so far. Not sure if this is a draft or if you wanted to go ahead and merge this? Approving so you're not blocked if you wanted to merge.
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Thanks for the review. This can be merged I guess. These docs will be part of the next release so it shouldn't confuse current users. |
Signed-off-by: Michel Hollands <michel.hollands@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com>
What this PR does / why we need it:
Checklist
CONTRIBUTING.md
guide (required)docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR