Terraform script to automate GCP provisioning for gcplog #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavirajk
commented
Jan 21, 2021
scripts/gcplog/main.tf
Outdated
| resource "google_logging_project_sink" "cloud-logs" { | ||
| name = var.logname | ||
| destination = "pubsub.googleapis.com/projects/personal-226821/topics/${var.logname}" | ||
| filter = "resource.type = gcs_bucket AND severity >= WARNING" |
There was a problem hiding this comment.
currently, filter is hardcoded. I will add it as variable in future.
There was a problem hiding this comment.
You should add to the doc a small section about this filter, the langage , what it does, and let's suggest a sane default ? What do you think would be a good default for someone that wants to get visibility into his cloud ?
There was a problem hiding this comment.
This might be a sane default. Perhaps we can link to GCP's filter documentation in the README, but I don't think we need to add much tooling here to change it -- this can serve as a template.
There was a problem hiding this comment.
I agree with filter doc and sane defaults.
- Added some explanation on the README with doc link
- I think sane default would be some cloud resource most of the customer be having.
httpLoadBalancer? so I added that. wdyt?
owen-d
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Automate Cloud provisioning part of GCP log
Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
These scripts will be run to configure GCP cloud to make cloud logs available for promtail.
Checklist