Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update distributor and compactor tests for native histograms #4352

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

codesome
Copy link
Member

@codesome codesome commented Mar 2, 2023

What this PR does

Syncs the updates in the unit tests for distributor and compactor done in sparsehistogram into main branch.

Requires #4354 to be merged

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@codesome codesome requested a review from a team as a code owner March 2, 2023 12:30
@codesome codesome requested a review from krajorama March 2, 2023 12:31
@codesome codesome marked this pull request as draft March 2, 2023 12:58
@codesome
Copy link
Member Author

codesome commented Mar 2, 2023

Converted this to draft since it requires changes to pkg/storage. I will open a PR for that first (Edit: PR for that #4354).

Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
@codesome codesome marked this pull request as ready for review March 6, 2023 10:07
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krajorama krajorama merged commit 5ad1837 into main Mar 6, 2023
@krajorama krajorama deleted the codesome/com-dis-tests branch March 6, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants