Prepare OnCall for Unified Slack App #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a modal on the alert group message, not mesasge action (in 3-dot menu).
Konstantinov-Innokentii
temporarily deployed
to
github-pages
GitHub Actions
Inactive
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Move slack installation & uninstallation code to separate functions to reuse betwen social-auth and chatops-proxy
Konstantinov-Innokentii
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Konstantinov-Innokentii
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Konstantinov-Innokentii
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Failure
matiasb
approved these changes
May 23, 2024
| "payload": { | ||
| # It's not actual payload we are getting from slack, just a placeholder | ||
| "slack_id" | ||
| "some_slack_id" |
There was a problem hiding this comment.
Thanks for noticing. missed a coma. Anyway, I went ahead and used a more accurate payload example from slack docs instead of placeholder
Konstantinov-Innokentii
had a problem deploying
to
github-pages
GitHub Actions
Error
Thanks! Added more tests covering our slack installation. |
…rafana/oncall into handle_chatops_proxy_broadcast
Konstantinov-Innokentii
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Konstantinov-Innokentii
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Konstantinov-Innokentii
temporarily deployed
to
github-pages
GitHub Actions
Inactive
vadimkerr
approved these changes
May 29, 2024
Konstantinov-Innokentii
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Konstantinov-Innokentii
temporarily deployed
to
github-pages
GitHub Actions
Inactive
brojd
approved these changes
Jun 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
This PR does a bunch of changes to prepare OnCall for Unified Slack App: 1. Install Slack via Chatops-Proxy. This change contains two parts: getting a Slack install link from chatops-proxy ([code](https://github.com/grafana/oncall/pull/4232/files#diff-437a77d49fc04b92d315651b3df5991000b1ab74cf60aabb21aa77cb2823bf52R46)) and receiving a "slack installed" event from chatops-proxy ([code](https://github.com/grafana/oncall/pull/4232/files#diff-976d106f0962be5c1de5e35582193f68435ed0c17f2defd6bd2857bf6e27f65d)). Also it means that OnCall doesn't need to register slack_links anymore when slack is connected/disconnected. These changes are behind UNIFIED_SLACK_APP_ENABLED flag and should be no-op if flag is not enabled. 2. Get rid of Multiregionatily restrictions - instrument all slack interactions with a ProxyMeta - json data telling chatops-proxy where to route the interaction. Note, that it doesn't apply for "Add to resolution notes" message action - it will be handled differently in following PR. 3. Move all chatops-proxy related stuff from common/oncall-gateway to apps/chatops-proxy Minor changes: 1. Remove usage of **CHATOPS_V3** flag. Chatops v3 is already released (It's a refactoring from previous quarter) --------- Co-authored-by: Vadim Stepanov <vadimkerr@gmail.com> Co-authored-by: Rares Mardare <rares.mardare@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of changes to prepare OnCall for Unified Slack App:
Minor changes: