This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Order stacktraces by ID to have a deterministic flamegraph #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Jul 26, 2022
pkg/querier/profile.go
Outdated
| result := make([]stacktraces, 0, len(stacktracesByID)) | ||
| for _, stacktrace := range stacktracesByID { | ||
| result = append(result, *stacktrace) | ||
| ids := make([]uint64, 0, len(stacktracesByID)) |
There was a problem hiding this comment.
ids := lo.Keys(stacktracesByID)
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…r-of-stacktraces-stable Order stacktraces by ID to have a deterministic flamegraph
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This orders the stacktraces based on the ID. This allows to output a deterministic flamegraph.
(It is worth trying to watch explore with an auto-refresh, then you can see the individual parts of it growing)
I don't think this should be optional. I have not checked it's impact, but that's probably the best position to order, as we already have the stacktrace ID.
Fixes #111