Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Conversation

cyriltovena
Copy link
Collaborator

This adds a basic profile selector in the query editor component for fire.

Work is still required for making the labels selector a bit more user friendly.

Builds and depends on #134 so we might want to merge it first.

image

Next I'm going to focus on returning profiling data.

Base automatically changed from datasource-ui to main August 2, 2022 09:14
Copy link
Member

@aocenas aocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just some nitpicks that aren't super important.

@cyriltovena
Copy link
Collaborator Author

Thanks @aocenas I'll take care of those.

@cyriltovena cyriltovena enabled auto-merge August 2, 2022 13:39
@cyriltovena cyriltovena merged commit e2d9559 into main Aug 2, 2022
@cyriltovena cyriltovena deleted the datasource-query-panel branch August 2, 2022 13:41
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
…anel

Add a Profile Selector Query Editor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants