This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Add Monaco editor and some basic language config #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aocenas
commented
Aug 3, 2022
| }; | ||
| } | ||
| onProfileTypeChange = (value: string[], selectedOptions: CascaderOption[]) => { | ||
| function onProfileTypeChange(value: string[], selectedOptions: CascaderOption[]) { |
There was a problem hiding this comment.
I changed this to function component mainly because at this moment it's a bit easier to use hooks for example to get grafana theme or to deal with async stuff.
aocenas
commented
Aug 3, 2022
| </div> | ||
| ); | ||
| function ensureFireQL(monaco: Monaco) { | ||
| if (fireqlSetupDone === false) { |
There was a problem hiding this comment.
This is a bit of rip off from our prometheus setup will have to find out if double init is really bad or why this is needed.
aocenas
force-pushed
the
aocenas/add-monaco-to-query-editor
branch
from
ba4aa0d to
3348aea
Compare
aocenas
commented
Aug 3, 2022
| height={'30px'} | ||
| containerStyles={styles.queryField} | ||
| monacoOptions={{ | ||
| folding: false, |
There was a problem hiding this comment.
Some overrides, also mostly taken from prometheus data source. At some point, it would probably make sense to have this as a different editor style constant or something like that.
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Add Monaco editor and some basic language config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this moment this does do much, just some basic syntax highlight but I assume we will add some autocomplete once we have labels/values API ready.