Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Conversation

cyriltovena
Copy link
Collaborator

This add the pyroscope API allowing to use fire in Grafana.

I had to remove the vendor folder to make it works, it seems that the linter is not happy.

@cyriltovena
Copy link
Collaborator Author

There's flakky test I need to resolve and the linter is not happy.

@cyriltovena
Copy link
Collaborator Author

Fixed the tests but the linter is not happy about generics trying to find a solution right now

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have tested this end 2 end and I couldn't find a way to break it.

Looked at a couple more test in depth, but certainly didn't fully grasph the toFlameBearer() method

@cyriltovena cyriltovena merged commit c22a041 into main Jun 15, 2022
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants