Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Implement /buildinfo and /config #299

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Implement /buildinfo and /config #299

merged 3 commits into from
Oct 13, 2022

Conversation

simonswine
Copy link
Collaborator

@simonswine simonswine commented Oct 7, 2022 •
edited
Loading

Fixes #286

This implements /api/v1/status/buildinfo:

{"status":"success", "data":{"version":"HEAD-1593cb88-WIP", "revision":"1593cb88", "branch":"HEAD", "buildUser":"", "buildDate":"", "goVersion":"go1.19.2"}}

and /api/v1/status/config,/api/v1/status/config/default, /api/v1/status/config/diff

@simonswine simonswine added the kind/enhancement New feature or request label Oct 7, 2022
@simonswine simonswine force-pushed the 20221007_build-info-config-endpoints branch 2 times, most recently from e5a0fcb to b615252 Compare October 10, 2022 08:23
@simonswine simonswine marked this pull request as ready for review October 10, 2022 08:31
@simonswine simonswine marked this pull request as draft October 10, 2022 08:32
@simonswine simonswine force-pushed the 20221007_build-info-config-endpoints branch from 4c35d84 to 27a08bc Compare October 10, 2022 09:17
@simonswine simonswine marked this pull request as ready for review October 10, 2022 09:46
@simonswine simonswine added this to the 0.2 milestone Oct 11, 2022
@simonswine simonswine force-pushed the 20221007_build-info-config-endpoints branch from 27a08bc to fddd203 Compare October 12, 2022 15:17
@simonswine
Copy link
Collaborator Author

@cyriltovena looks like we implement /config in parallel, do you mind if we actually pull that into v0.1?

cyriltovena
cyriltovena reviewed Oct 13, 2022
View reviewed changes
cyriltovena
cyriltovena approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPGTM

@cyriltovena
Copy link
Collaborator

config

Let's go !

@simonswine simonswine enabled auto-merge October 13, 2022 07:29
@simonswine simonswine merged commit e2d0eaf into main Oct 13, 2022
@simonswine simonswine deleted the 20221007_build-info-config-endpoints branch October 13, 2022 07:37
simonswine added a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
@simonswine
Merge pull request grafana/phlare#299 from grafana/20221007_build-inf…
6e438e4 
…o-config-endpoints

Implement /buildinfo and /config
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aocenas aocenas Awaiting requested review from aocenas

1 more reviewer

@cyriltovena cyriltovena cyriltovena approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.

Add BuildInfo like API
2 participants
@simonswine @cyriltovena