This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Refactor gzip reading/writing #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
added a commit
that referenced
this pull request
Oct 20, 2022
This is because the mapping ID is set to 0 on the locations. It also adds an uncompressed profile that should be solved by #338.
Allow reading of compressed and uncompressed data whenever we read a profile from bytes through shared code. Also reader/writers and buffers are pooled.
simonswine
force-pushed
the
20221020_generic-gzip-reader
branch
from
17a182d to
240c6a3
Compare
cyriltovena
approved these changes
Oct 21, 2022
simonswine
added a commit
that referenced
this pull request
Oct 21, 2022
This is because the mapping ID is set to 0 on the locations. It also adds an uncompressed profile that should be solved by #338.
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…zip-reader Refactor gzip reading/writing
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
This is because the mapping ID is set to 0 on the locations. It also adds an uncompressed profile that should be solved by grafana/phlare#338.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow reading of compressed and uncompressed data whenever we read a
profile from bytes through shared code. Also reader/writers and buffers
are pooled.