Skip to content
This repository was archived by the owner on Jul 19, 2023. It is now read-only.

Conversation

simonswine
Copy link
Collaborator

@simonswine simonswine commented Jun 17, 2022

This also includes the response body of the non 2xx response, so it is clearer what is wrong with the scrape.

Before:

$ curl -s localhost:4100/targets | jq '.activeTargets[] | select(.lastError!="") | .lastError' | sort -u
"server returned HTTP status 500 Internal Server Error"

After:

$ curl -s localhost:4100/targets | jq '.activeTargets[] | select(.lastError!="") | .lastError' | sort -u
"server returned HTTP status (500) Could not enable CPU profiling: cpu profiling already in use"

This also includes the response body of the non 2xx response, so it is
clearer what is wrong with the scrape.
@simonswine simonswine marked this pull request as ready for review June 17, 2022 08:27
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonswine simonswine merged commit a0fe571 into main Jun 17, 2022
simonswine added a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
…raping-error-passing

Improve error message from scraper
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants