This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Fixes delta of samples computation #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
commented
Mar 23, 2023
cyriltovena
commented
Mar 23, 2023
simonswine
approved these changes
Mar 23, 2023
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Fixes delta of samples computation * ignore wrong lint error * Review feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the computation of delta profiles. We were assuming that only one sample per stacktraces is passed to the delta function.
However this wasn't true, after ingesting symbols we can endup with the same stacktraces in different samples.
This PR makes sure that before computing the samples we sanitize the input.
I've also included couple of fixes to avoid retaining the memory here and there and combine with correct delta this has drastically improve performance of ingester.
This is the result in a busy cluster.