This repository was archived by the owner on Jul 19, 2023. It is now read-only.
Refactor all APIs to a better structure #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xPoe
commented
Apr 18, 2023
0xPoe
changed the title
0xPoe
force-pushed
the
rustin-patch-API-refactor
branch
from
54978bd to
0456310
Compare
0xPoe
changed the title
cyriltovena
approved these changes
Apr 19, 2023
Did you ask why we copy the gizp code or why we add gzip support? From the comment: // Package gziphandler mirrors the package github.com/nytimes/gziphandler
// until https://github.com/nytimes/gziphandler/pull/112 is merged.
// Once it's merged, we can delete it from here and switch back to using that one. |
|
Tested it locally: |
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Refactor all APIs to a better structure * Resolve conflicts * Move all into api.go * Refine the deps * Fix broken APIs * Fix lint * Refine the auth * Better order * Add api test * Fix panic * Fix broken UI * Add `/ingest` API
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #587
close #637
Adapt the gzip support from Mimir as well.