Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retries are broken #113

Closed
korniltsev opened this issue Sep 5, 2023 · 1 comment
Closed

Retries are broken #113

korniltsev opened this issue Sep 5, 2023 · 1 comment

Comments

@korniltsev
Copy link
Collaborator

We should not retry on invalid profiles.

2023-09-05 14:40:35.087 [ERROR] Error uploading snapshot: 400 the profile with labels '{name="wall", delta="false", service_name="demo.app", jfr_event="wall", pyroscope_spy="javaspy", region="us-east-1", user="tolyan", qweqwe="asdasd"}' exceeds the samples count limit (max_profile_stacktrace_samples, actual: 16753, limit: 16000)

Maybe we should not retry at all.
@cyriltovena
Copy link

Correct 4xx should never be retried only 5xx,429 or connection issues.

@korniltsev korniltsev mentioned this issue Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@korniltsev @cyriltovena