Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ingestion path replication #6

Closed
joe-elliott opened this issue Jan 30, 2020 · 1 comment
Closed

Fix ingestion path replication #6

joe-elliott opened this issue Jan 30, 2020 · 1 comment

Comments

@joe-elliott
Copy link
Member

We may have gotten too excited during the great butchering of Loki and removed more than was intended. In the distributor there is a method routeRequest that breaks a PushRequest up by traceid and forwards it to the appropriate ingesters based on tokens/replication factor. After this the distributor sends

Unfortunately it lost the ability to check for concensus on write. Readd this. Look at the replicationSet.Do() method from Cortex b/c I think it does this already.

@joe-elliott
Copy link
Member Author

This is basically covered by #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant