Unescape query strings in lambda #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
mdisibio,
mapno,
yvrhdn and
zalegrala
as code owners
zalegrala
approved these changes
Feb 22, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-2120-to-release-v2.0 origin/release-v2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 161266cab486765ead60806604b2f42e89506be8
# Push it to GitHub
git push --set-upstream origin backport-2120-to-release-v2.0
git switch main
# Remove the local backport branch
git branch -D backport-2120-to-release-v2.0Then, create a pull request where the |
joe-elliott
added a commit
that referenced
this pull request
Feb 23, 2023
* unescape strings in lambda Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * add tests Signed-off-by: Joe Elliott <number101010@gmail.com> * update mod Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> (cherry picked from commit 161266c)
joe-elliott
added a commit
that referenced
this pull request
Feb 23, 2023
* unescape strings in lambda Signed-off-by: Joe Elliott <number101010@gmail.com> * changelog Signed-off-by: Joe Elliott <number101010@gmail.com> * add tests Signed-off-by: Joe Elliott <number101010@gmail.com> * update mod Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com> (cherry picked from commit 161266c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Correctly unescapes parameter values in AWS Lambda
Which issue(s) this PR fixes:
Fixes #2114
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]