Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Updates from backport 2563 #2580

Merged
merged 4 commits into from
Jun 27, 2023
Merged

[DOC] Updates from backport 2563 #2580

merged 4 commits into from
Jun 27, 2023

Conversation

knylander-grafana
Copy link
Contributor

@knylander-grafana knylander-grafana commented Jun 22, 2023

What this PR does:

Update the docs on /next with updates done in PR#2569.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@knylander-grafana
Copy link
Contributor Author

knylander-grafana commented Jun 22, 2023

From @ie-pham :

Can we add information about MetricsIngestionSlack (in cloud we are defaulting this to 30s) so all spans sent to the metrics-generator with an end time more than 30s in the past would get discarded/rejected. This metrics is exposed in metrics_generator_spans_discarded_total
https://github.com/grafana/tempo/blob/main/modules/generator/config.go#L35

This content was added in PR #2424 (slated for the next release) so it should only appear in /next.

Copy link
Contributor

@ie-pham ie-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved from metrics-generator perspective 🙏 thank you Kim!

@knylander-grafana knylander-grafana merged commit e680bda into grafana:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants