Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Adding missing
metric-generator
keys #3643[DOC] Adding missing
metric-generator
keys #3643Changes from 10 commits
d8360dd
5cb42ca
3432de4
d67d432
e2b5b8c
1ce273c
5e41652
e86d251
afdc378
6182718
5b0fc94
25d8da5
f596e4e
900a636
603041a
b44916a
93af96b
430dd49
0e4b16a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 34 in docs/sources/tempo/configuration/_index.md
GitHub Actions / doc-validator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed a way to show that this particular component is overriding values from the base component block. (WAL Config)
Wanted to keep it light for the future, so no comments where none would add additional value.
If there were comments we would need to keep both synchronized.
This way if you are making changes to the
query-frontend
you won't need to change the base block because it isn't dependant on thequery-frontend
Same in reverse, if you made changes to the base
WAL Config
you wouldn't need to propagate them to every component that use it. (Unless you made changes to them too)Feel free to dispute the omission of the newline breaks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found a bug?
I described what the code does here, but I don't think this is the intended behaviour...
Please verify :
tempo/tempodb/wal/wal.go
Lines 70 to 75 in 3a4f309
I think it's supposed to look like this (but with
c.BlocksFilepath == ""
):tempo/tempodb/wal/wal.go
Lines 56 to 67 in 3a4f309
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right @WesselAtWork. It is overwriting the config always. Please feel free to create a PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WesselAtWork , I've created a bug issue here: #3902
Would you add additional details?