Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Upgrade Cortex #841

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Chore: Upgrade Cortex #841

merged 3 commits into from
Jul 28, 2021

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jul 28, 2021 •
edited by annanay25
Loading

What this PR does:
Upgrade to latest Cortex.

Changes from Cortex v1.9.0 until a4bf10354786.

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • NA Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@aknuds1
Chore: Upgrade Cortex
2c76e66 
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jul 28, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aknuds1 aknuds1 added the chore label Jul 28, 2021
@aknuds1 aknuds1 marked this pull request as ready for review July 28, 2021 06:38
annanay25
annanay25 reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @aknuds1

Could you link the changelog between the old and new commit please? We would have to comb through it and look for any changes that might affect us.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jul 28, 2021

Thanks for the update @aknuds1

Could you link the changelog between the old and new commit please? We would have to comb through it and look for any changes that might affect us.

@annanay25 OK, will do.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jul 28, 2021

@annanay25 added change comparison link between the two Cortex commits. Hope it's what you need.

@yvrhdn
Copy link
Member

yvrhdn commented Jul 28, 2021

The CHANGELOG is probably easier to parse.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jul 28, 2021

The CHANGELOG is probably easier to parse.

Thanks @kvrhdn

yvrhdn
yvrhdn approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@yvrhdn yvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a lot of changes impacting Tempo, looks good to me 👍
Glad this upgrade went smoother than my upgrade a couple of weeks ago 😅

annanay25
annanay25 reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant changes:

Also, do we need to backport this change - cortexproject/cortex#4375

annanay25
annanay25 approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

annanay25
annanay25 reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a CHANGELOG entry. This is looking good to go.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Jul 28, 2021

Can you please add a CHANGELOG entry. This is looking good to go.

Thanks @annanay25, done.

@annanay25 annanay25 merged commit d50c64b into main Jul 28, 2021
@annanay25 annanay25 deleted the chore/upgrade-cortex branch July 28, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annanay25 annanay25 annanay25 approved these changes

@yvrhdn yvrhdn yvrhdn approved these changes

@dgzlopes dgzlopes Awaiting requested review from dgzlopes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aknuds1 @CLAassistant @yvrhdn @annanay25