Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes test results #189

Closed
wants to merge 1 commit into from
Closed

Fixes test results #189

wants to merge 1 commit into from

Conversation

spinillos
Copy link
Member

Tests were failing because they have invalid path in results 🤷🏼‍♀️

@spinillos
Copy link
Member Author

If I fix lineage_test.go, vanilla_txtar.go fails 😂: drone link

@spinillos
Copy link
Member Author

go test -v ./... works in local and CI, but lineage_test.go fails if you execute it independently

@sdboyer
Copy link
Contributor

sdboyer commented Jul 23, 2023

oh, ugh. i'm guessing that's relative path loading issues, given a different cwd when invoking go test from different subpaths within the repo, vs. invoking from repo root.

i'm not sure what changed to make this suddenly become a problem...seems like a good case for some git bisect

@spinillos
Copy link
Member Author

I'm going to close it for now. I created that only to fix that test and it should be different 😅.

@spinillos spinillos closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K-Phoen K-Phoen Awaiting requested review from K-Phoen

@joanlopez joanlopez Awaiting requested review from joanlopez

@undef1nd undef1nd Awaiting requested review from undef1nd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spinillos @sdboyer