Desobekify Browser
#1389
Merged
Desobekify Browser
#1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allansson
approved these changes
Jun 25, 2024
- Moves BrowserContextOptions out of the business logic. - Sets default options in NewBrowserContext to prevent nil pointer issues in the rest of the module. Later, we might think about turning some of these pointer fields into value types to take advantage of their zero values.
inancgumus
force-pushed
the
desobekify/browser
branch
from
3f26d5c to
2b13ae1
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
BrowserContextOptionsout of the business logic.NewBrowserContextto prevent nil pointer issues in the rest of the module. Later, we can turn some of these pointer fields into value types to take advantage of their zero values.Note
These changes should had to be made in the single commit to be atomic.
Why?
See #1269.
Checklist