Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Check if we are in-cluster when kubeconfig is empty #101

Merged
merged 1 commit into from
Aug 23, 2023
Merged

feat: Check if we are in-cluster when kubeconfig is empty #101

merged 1 commit into from
Aug 23, 2023

Conversation

JorTurFer
Copy link
Contributor

@JorTurFer JorTurFer commented Aug 23, 2023 •
edited
Loading

Signed-off-by: Jorge Turrado jorge.turrado@scrm.lidl

Fixes #100

@JorTurFer
Check if we are in-cluster when kubeconfig is empty before overriding it
e2f6e51 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer mentioned this pull request Aug 23, 2023
Closed
@javaducky javaducky self-requested a review August 23, 2023 15:07
pablochacin
pablochacin approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

javaducky
javaducky approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@javaducky javaducky merged commit ad619e1 into grafana:main Aug 23, 2023
7 checks passed
@JorTurFer
Copy link
Contributor Author

I have introduced by error a duplicated import 🤦
I've opened another PR fixing it: #102

@JorTurFer
Copy link
Contributor Author

I do confirm that now it works in-cluster, we are already using this extension and we can create resources inside the cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javaducky javaducky javaducky approved these changes

@pablochacin pablochacin pablochacin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xk6-kubernetes extension can't be used in-cluster
3 participants
@JorTurFer @pablochacin @javaducky