Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/gin-gonic/gin from 1.6.3 to 1.9.0 #49

Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github May 5, 2023

Bumps github.com/gin-gonic/gin from 1.6.3 to 1.9.0.

Release notes

Sourced from github.com/gin-gonic/gin's releases.

v1.9.0

Changelog

BREAK CHANGES

  • Stop useless panicking in context and render #2150

BUG FIXES

  • fix(router): tree bug where loop index is not decremented. #3460
  • fix(context): panic on NegotiateFormat - index out of range #3397
  • Add escape logic for header #3500 and #3503

SECURITY

  • Fix the GO-2022-0969 and GO-2022-0288 vulnerabilities #3333
  • fix(security): vulnerability GO-2023-1571 #3505

ENHANCEMENTS

  • feat: add sonic json support #3184
  • chore(file): Creates a directory named path #3316
  • fix: modify interface check way #3327
  • remove deprecated of package io/ioutil #3395
  • refactor: avoid calling strings.ToLower twice #3343
  • console logger HTTP status code bug fixed #3453
  • chore(yaml): upgrade dependency to v3 version #3456
  • chore(router): match method added to routergroup for multiple HTTP methods supporting #3464
  • chore(http): add support for go1.20 http.rwUnwrapper to gin.responseWriter #3489

DOCS

  • docs: update markdown format #3260
  • docs(readme): Add the TOML rendering example #3400
  • docs(readme): move more example to docs/doc.md #3449
  • docs: update markdown format #3446

v1.8.2

Changelog

Bug fixes

  • 0c2a691 fix(engine): missing route params for CreateTestContext (#2778) (#2803)
  • e305e21 fix(route): redirectSlash bug (#3227)

Others

  • 6a2a260 Fix the GO-2022-1144 vulnerability (#3432)

v1.8.1

Changelog

... (truncated)

Changelog

Sourced from github.com/gin-gonic/gin's changelog.

Gin v1.9.0

BREAK CHANGES

  • Stop useless panicking in context and render #2150

BUG FIXES

  • fix(router): tree bug where loop index is not decremented. #3460
  • fix(context): panic on NegotiateFormat - index out of range #3397
  • Add escape logic for header #3500 and #3503

SECURITY

  • Fix the GO-2022-0969 and GO-2022-0288 vulnerabilities #3333
  • fix(security): vulnerability GO-2023-1571 #3505

ENHANCEMENTS

  • feat: add sonic json support #3184
  • chore(file): Creates a directory named path #3316
  • fix: modify interface check way #3327
  • remove deprecated of package io/ioutil #3395
  • refactor: avoid calling strings.ToLower twice #3343
  • console logger HTTP status code bug fixed #3453
  • chore(yaml): upgrade dependency to v3 version #3456
  • chore(router): match method added to routergroup for multiple HTTP methods supporting #3464
  • chore(http): add support for go1.20 http.rwUnwrapper to gin.responseWriter #3489

DOCS

  • docs: update markdown format #3260
  • docs(readme): Add the TOML rendering example #3400
  • docs(readme): move more example to docs/doc.md #3449
  • docs: update markdown format #3446

Gin v1.8.2

BUG FIXES

  • fix(route): redirectSlash bug (#3227)
  • fix(engine): missing route params for CreateTestContext (#2778) (#2803)

SECURITY

  • Fix the GO-2022-1144 vulnerability (#3432)

Gin v1.8.1

ENHANCEMENTS

... (truncated)

Commits
  • ea03e10 docs(readme): release v1.9.0 version (#3474)
  • 4cee78f Fix #3500 Add escape logic for header (#3503)
  • fc1c432 fix(security): vulnerability GO-2023-1571 (#3505)
  • 81ac7d5 Add escape logic for header (#3500)
  • d07db17 chore(deps): bump golang.org/x/net from 0.5.0 to 0.6.0 (#3498)
  • c1d06e3 add supprt for go1.20 http.rwUnwrapper to gin.responseWriter (#3489)
  • bd82c9e chore(go): Add support go 1.20 (#3484)
  • 0c96a20 Stop useless panicking in context and render (#2150)
  • 153b229 chore(deps): bump github.com/ugorji/go/codec from 1.2.8 to 1.2.9 (#3491)
  • e02ae6a chore(router): match method added to routergroup for multiple HTTP methods su...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

jcharum and others added 30 commits October 1, 2020 14:06
When we synced 4ef097c#diff-8b7b38c62b815a44970c5332bcadd718R64-R72 from our internal repository, we introduced a dependence on `ssh-keygen` support of the `-` argument to read from standard input. The version of `ssh-keygen` shipped on trusty does not support it. Upgrade our build to use xenial. (We may consider upgrading further, but I am trying to make the minimal changes to make our CI build succeed again).
Co-authored-by: Jaran Charumilind <jcharumilind@grailbio.com>
Summary:
Allow ticket-server to grant Kubernetes pods a v23 identity.

Given a request with a `ca.crt`, `namespace`, and service account `token`, query the Kubernetes cluster API server to verify the token. Verify that the request `ca.crt` is in the allow list of clusters.

Request times:
28 AWS accounts across 3 regions -> 23.89s
28 AWS accounts across 1 region (closest to what we will run in prod)-> 4.4s
5 AWS accounts across 3 regions -> 8.93s

Design Doc: https://docs.google.com/document/d/1-MxDlRT5JPucktIzjNfRFFmPjjXNjdmi5xjpjGQ2KU8/edit#

Closes T39592

Test Plan: Verify flow locally by granting a v23 identity from a local ticket-server using a Kubernetes cluster in the dev environment to authenticate the token.

Reviewers: O9 ticket-server, aeiser, O3 third-party, joshnewman, bbentson

Reviewed By: O9 ticket-server, O3 third-party, joshnewman, bbentson

Subscribers: joshnewman, bbentson, aeiser, jcharumilind, pgopal, dnicolaou, pboyapalli

Maniphest Tasks: T39579, T39592

Differential Revision: https://phabricator.grailbio.com/D47646

fbshipit-source-id: 3513e59
Summary:
This command will be run from a Kubernetes pod. It will request a v23 identity from the ticket-server using the /blesser/k8s endpoint and pass in caCrt, namespace, and service account token.

Design Doc: https://docs.google.com/document/d/1-MxDlRT5JPuckitIzjNfRFFmPjjXNjdmi5xjpjGQ2KU8/edit#

Closes T39590

Test Plan:
Verify flow locally.

Grant a v23 identity from a local ticket-server using a Kubernetes cluster in the dev environment to authenticate the token.

Subscribers

Reviewers: #security, aeiser, O9 ticket-server, joshnewman, bbentson

Reviewed By: #security, O9 ticket-server, joshnewman, bbentson

Subscribers: bbentson, joshnewman, smahadevan

Maniphest Tasks: T39590

Differential Revision: https://phabricator.grailbio.com/D47876

fbshipit-source-id: e77e5a8
Summary:
This adds SetInterval and ClearInterval functions which efficiently
set/clear a block of bits, along with NewSetBits()/NewClearBits()
convenience functions.

Test Plan: Unit test added.

Reviewers: ayip

Reviewed By: ayip

Subscribers: cchang, smahadevan

Maniphest Tasks: T20121

Differential Revision: https://phabricator.grailbio.com/D48407

fbshipit-source-id: 7aad6f4
Summary: agentlib is deprecated in the newest versions of vanadium. This diff will make upgrading our vanadium version easier.

Test Plan: Ran `grail-access` locally and updated unit tests.

Reviewers: #security, aeiser

Reviewed By: #security, aeiser

Subscribers: joshnewman, smahadevan

Differential Revision: https://phabricator.grailbio.com/D50485

fbshipit-source-id: 8e017ed
Summary:
Update the method comment on `Each` to warn developers about a potential
deadlock state when panics occur in concurrent goroutines.

Ref T43383

Test Plan: Verify that the code still compiles and bazel build passes.

Reviewers: arinehouse, ecarrel

Reviewed By: ecarrel

Subscribers: smahadevan

Tags: #software-only_change_control, #platform-wide

Maniphest Tasks: T43383

Differential Revision: https://phabricator.grailbio.com/D50868

fbshipit-source-id: f8d8ada
Summary:
This reverts commit 8e017ede14a0ea4fe00b428eee8fbae20a27306c.

This change is causing issues because we removed the v23agent without upgrading Vanadium. This change will be included in the diff where we upgrade the Vanadium version.

Test Plan: Unit tests.

Reviewers: aeiser

Reviewed By: aeiser

Subscribers: smahadevan

Differential Revision: https://phabricator.grailbio.com/D50927

fbshipit-source-id: dea4e06
Summary:
A new alternative to D46489 and D48243. This takes a different approach of
more explicitly managing transports tuned for S3 access.

Test Plan:
New unit tests.

Enabled new transport in (manually-run) integration tests, and ran them.

Reviewers: jcharumilind

Reviewed By: jcharumilind

Subscribers: aeiser, jschellenberger, smahadevan

Maniphest Tasks: T38104

Differential Revision: https://phabricator.grailbio.com/D48772

fbshipit-source-id: 6329221
Summary:
There was a bug where memory usage could be under counted.

Adds compaction to the intervalset.  At certain strategic times, adjacent
intervals in the interval set will be merged and de-duplicated.

Test Plan: updated unit tests

Reviewers: joshnewman

Reviewed By: joshnewman

Subscribers: anandi, jcharumilind, smahadevan

Maniphest Tasks: T38940

Differential Revision: https://phabricator.grailbio.com/D51318

fbshipit-source-id: abdd8ac
Summary:
Open Sourcing the common logging library so it can be used by services in github.com  directory, such as ticket-server.

Closes T43907.

Test Plan: Make sure builds pass.

Reviewers: O50 galleri/communications, O56 Ensemble backend, O15 scrms, #security, treaster, jgalilee, tule

Reviewed By: O50 galleri/communications, O56 Ensemble backend, O15 scrms, #security, jgalilee, tule

Subscribers: aeiser, jcharumilind, dnicolaou, pboyapalli, smahadevan

Maniphest Tasks: T43907

Differential Revision: https://phabricator.grailbio.com/D51322

fbshipit-source-id: d62074e
Summary: Switch ticket-server logger from vlog to our common, structured logger. Once we upgrade v.io, we should be able to include `requestID` in each log message that is unique to each server request. This will greatly improve ticket-server logging as it will allow us to corroborate multiple and simultaneous log messages.

Test Plan:
Instantiate local ticket-server, make requests against it, and verify logs and functionality.

Improved logging messages:
https://phabricator.grailbio.com/P1133

Reviewers: O9 ticket-server, aeiser

Reviewed By: O9 ticket-server, aeiser

Subscribers: jcharumilind, dnicolaou, pboyapalli, smahadevan

Maniphest Tasks: T43900

Differential Revision: https://phabricator.grailbio.com/D51308

fbshipit-source-id: 289ed44
Summary:
Add debug level logging, improve godoc documentation. These changes were requested by Fed.

Also add unit test for nil ctx.

Closes T44568

Test Plan: Update unit tests.

Reviewers: fdegiuli, treaster, adharwadkar

Reviewed By: fdegiuli

Subscribers: #security, smahadevan

Maniphest Tasks: T44568

Differential Revision: https://phabricator.grailbio.com/D51994

fbshipit-source-id: 45024c8
Summary:
Configure `tfwrap` with a profile specified in the classifier evaluation binary. We previously used configuration from `$HOME/grail/profile`, however this had at least two problems:

# It wasn't captured anywhere for reproducibility.
# It was a second place to deal with for configuration, in addition to `trainer_params`.

Since D51112, Chiron itself uses a `base/config` profile for configuration. In this revision, add `tfexec` things to that profile default, and now pass it as a command line argument via `tfwrap` for use by `tfexec`. This means that all profile configuration happens in `trainer_params`, and `$HOME/grail/profile` is defunct.

Profiles are only included if you specify `chiron_eval_binary(..., pass_profile = True, ...)`. In practice, you probably want to set this if and only if you are specifying a binary built with `tfexec_binary` as your trainer.

`tfwrap` no longer reads from `$HOME/grail/profile` to prevent accidental inclusion of configuration that prevents reproduction, however you can still invoke it directly with a `--profile your-profile` argument.

Test Plan: Run unit tests. Run with different configurations of the `sexandage` trainer.

Reviewers: O52 chiron infrastructure, joshnewman, soheil

Reviewed By: O52 chiron infrastructure, joshnewman

Subscribers: smahadevan

Tags: #chiron

Maniphest Tasks: T42162, T40897

Differential Revision: https://phabricator.grailbio.com/D51908

fbshipit-source-id: 72662d5
Summary:
Update the long description of grail-ticket to use `grail-ticket` instead of `grail ticket` and use the `tickets/eng/dev/aws`, which every engineer should have access to. Also re-generate doc.go to update.

Closes T44662

Test Plan: Careful eyes.

Reviewers: #security, aeiser

Reviewed By: #security, aeiser

Subscribers: smahadevan

Maniphest Tasks: T44662

Differential Revision: https://phabricator.grailbio.com/D52004

fbshipit-source-id: ac90ed7
Summary:
Create logging functions without a `ctx` to support logging in situations without a context.

Closes T44734

Test Plan: Update unit tests.

Reviewers: fdegiuli, treaster, adharwadkar

Reviewed By: fdegiuli

Subscribers: adharwadkar, smahadevan

Maniphest Tasks: T44734

Differential Revision: https://phabricator.grailbio.com/D52138

fbshipit-source-id: 4daca99
Summary:
Changed vlog to common logger
Where ever the context was not available in "main" like function, context.Background() context was used. In the NoCtx variations of the logger, the context.Background() is used (suggested by @treaster)

Test Plan: This should be printing the same message as original message. No change in functionality is expected.

Reviewers: noah, O56 Ensemble backend, fdegiuli

Reviewed By: O56 Ensemble backend, fdegiuli

Subscribers: noah, treaster, smahadevan, fdegiuli

Differential Revision: https://phabricator.grailbio.com/D51822

fbshipit-source-id: 776f0ce
Summary:
Upgrade from Vanadium v0.1.6 to v0.1.14.

Closes T42157.

Test Plan:
Verify Vanadium upgraade on local instances of ticket-server (Noah), LIMS (Richard), and Pipeline (Phillip).
https://docs.google.com/document/d/12ySNMFTUCY4F3rCmp2pJn2LzsgxZgn-JMbmijHycjCU/edit#

Testing done by @rhuang T43601

Reviewers: O9 ticket-server, O17 Instruments Service, O28 Grailbook Infra, O5 pipeline, O34 Pre/Post, O10 LIMS Server, O6 EDC, O3 third-party, O56 Ensemble backend, O57 Patient Service Backend, O50 galleri/communications, aeiser, tule, rhuang, O58 Shipment Service owner, pbohannon, byang, ajonnavithula

Reviewed By: O9 ticket-server, O17 Instruments Service, O28 Grailbook Infra, O5 pipeline, O34 Pre/Post, O10 LIMS Server, O6 EDC, O3 third-party, O56 Ensemble backend, O57 Patient Service Backend, O50 galleri/communications, aeiser, tule, rhuang, O58 Shipment Service owner, pbohannon, byang, ajonnavithula

Subscribers: fdegiuli, aahn, rhuang, krestivo, aeiser, pbohannon, jcharumilind, pgopal, smahadevan, dnicolaou, pboyapalli, #lab_testing

Maniphest Tasks: T42157

Differential Revision: https://phabricator.grailbio.com/D50466

fbshipit-source-id: 404e476
Summary:
I do not plan on landing this diff. It is simply here so we have a revert diff ready in case the Vanadium update diff D50466 causes unexpected issues.

Revert "v.io: update to v0.1.14"

This reverts commit e48affa9ec12d8152370e745be8c381acfd7651a.

Reviewers: O9 ticket-server, O17 Instruments Service, O50 galleri/communications!, O28 Grailbook Infra, O58 Shipment Service owner, O5 pipeline, O56 Ensemble backend, O34 Pre/Post, O57 Patient Service Backend, O10 LIMS Server, O6 EDC, O3 third-party, aeiser, rhuang, pbohannon, ajonnavithula, ecarrel

Reviewed By: O9 ticket-server, O17 Instruments Service, O28 Grailbook Infra, O58 Shipment Service owner, O5 pipeline, O56 Ensemble backend, O34 Pre/Post, O57 Patient Service Backend, O10 LIMS Server, O6 EDC, O3 third-party, aeiser, rhuang, pbohannon, ajonnavithula, ecarrel

Subscribers: aeiser, jcharumilind, smahadevan, dnicolaou, pboyapalli, #lab_testing

Differential Revision: https://phabricator.grailbio.com/D52269

fbshipit-source-id: 3d0d90c
Summary:
Upgrade from Vanadium to v0.1.15.

This diff is based on D50466. D50466 was reverted by D52269.

D50466 upgraded Vanadium to v0.1.14. There are no significant changes between v0.1.14 and v0.1.15, except the bugfix for an issue we discovered in the Vanadium source code: the `dir.lock` file in the credentials directory is not generated during the runtime factory initialization, even when the read-only flag is not set.

This diff will include the commit that fixes that bug so that the `dir.lock` file is properly created.

```
$ git diff D52508 D50466 --name-only

go/src/github.com/grailbio/base/go.mod
go/src/github.com/grailbio/base/go.sum
go/src/github.com/grailbio/bigmachine/go.sum
go/src/github.com/grailbio/bigslice/go.sum
go/src/github.com/grailbio/bio/go.sum
go/src/github.com/grailbio/diviner/go.sum
go/src/github.com/grailbio/doppelmark/go.sum
go/src/github.com/grailbio/gql/go.sum
go/src/github.com/grailbio/grit/go.sum
go/src/github.com/grailbio/hts/go.sum
go/src/github.com/grailbio/infra/go.sum
go/src/github.com/grailbio/ml/go.sum
go/src/github.com/grailbio/reflow/go.sum
go/src/github.com/grailbio/v23/factories/grail/go.mod
go/src/github.com/grailbio/v23/factories/grail/go.sum
go/src/grail.com/bigslice/sliceflags/v23.go
go/src/grail.com/billing/server/vanadium/vdl/account/account.vdl.go
go/src/grail.com/go.mod
go/src/grail.com/go.sum
go/src/grail.com/pipeline/director/services/release_test.go
go/src/grail.com/pipeline/director/services/worker_test.go
go/src/grail.com/pipeline/ifc/ifc.vdl.go
go/src/vendor/v.io/x/ref/lib/security/util.go
third-party/go/repositories.bzl
```

Full paste of diff D52508 D50466:
https://phabricator.grailbio.com/P1247

Test Plan:
There was already significant testing done for D50466 with Noah verifying the ticket-server behavior in staging environment, Richard on LIMS, and Philip on Pipeline.
Testing done by @rhuang T43601

The additional test for this diff is to verify that old credentials (geneated with old grail-access) is compatible with new grail-ticket. This was verified by Noah.

Closes T42157.

Reviewers: O9 ticket-server, O17 Instruments Service, O50 galleri/communications, O28 Grailbook Infra, O58 Shipment Service owner, O5 pipeline, O56 Ensemble backend, O34 Pre/Post, O57 Patient Service Backend, O10 LIMS Server, O6 EDC, O3 third-party, rhuang, aeiser, jgalilee, pbohannon, fdegiuli, lkong, ajonnavithula

Reviewed By: O9 ticket-server, O17 Instruments Service, O50 galleri/communications, O28 Grailbook Infra, O58 Shipment Service owner, O5 pipeline, O56 Ensemble backend, O34 Pre/Post, O57 Patient Service Backend, O10 LIMS Server, O6 EDC, O3 third-party, rhuang, aeiser, jgalilee, pbohannon, fdegiuli, lkong, ajonnavithula

Subscribers: joshnewman, jcharumilind, smahadevan, dnicolaou, pboyapalli, rhuang, #lab_testing

Maniphest Tasks: T42157

Differential Revision: https://phabricator.grailbio.com/D52508

fbshipit-source-id: a445ca1
Summary: With the v23 update to v0.1.15, the vcontext should now include a request id per v23 request.

Test Plan: Verified in local instantiation of ticket-server's logs.

Reviewers: fdegiuli, treaster, aeiser

Reviewed By: aeiser

Subscribers: smahadevan

Differential Revision: https://phabricator.grailbio.com/D52769

fbshipit-source-id: 2952ca9
Summary:
Update the `grail-ticket`  to support a flag, `-list`, that lists all the tickets accessible to the user.

To support this on the ticket-server side, a new function, `List()`, was added. `List()` iterates over all tickets and queries Google Groups API to see if the user has access. It then returns a sorted list of accessible tickets.

Example:
```
$ grail-ticket -list tickets
aws-grail-eng-sandbox/admin/aws
aws-grail-eng-sandbox/test/aws
eng/dev/admin
eng/dev/aws
eng/go-testing/aws
eng/go-testing/aws.perm
security/admin/aws
security/veeva/sbx-svc-logging-password
security/veeva/sbx-svc-logging-user
ti-apps/admin/aws
ti-apps/ticket-server/aws
```

From my local testing, the command takes 55-60s.

Test Plan: Instantiated ticket-server locally and ran `grail-ticket -list` against it.

Reviewers: O9 ticket-server, #security, aeiser

Reviewed By: O9 ticket-server, #security, aeiser

Subscribers: aeiser, smahadevan

Differential Revision: https://phabricator.grailbio.com/D52062

fbshipit-source-id: 6afaffc
Summary:
Automatically find identical strings and save memory by using the same underlying memory.
Does not work on unexported fields, which is a fairly big loophole.

For exampleSet, string interning saves 6% of memory as measured by DeepSize()

Test Plan:
unit tests for string interning method.
tested on exampleSet showing 6% memory savings

Reviewers: joshnewman

Reviewed By: joshnewman

Subscribers: afields, sbagaria, kdavydov, jcharumilind, smahadevan

Differential Revision: https://phabricator.grailbio.com/D52589

fbshipit-source-id: 97679c1
Summary: Previously, registering the empty string "" endpoint was causing glob to fail. So, we will change the endpoint to be "list" and append "list" to the path.

Test Plan:
Deployed locally and to staging tickets-testing ticket-server and verified flow with:
```
grail-ticket -list tickets-testing
```
Also verified that the glob functionality still works:
```
namespace glob tickets-testing/...
```

Reviewers: O9 ticket-server, bbentson

Reviewed By: O9 ticket-server, bbentson

Subscribers: aeiser, bbentson, smahadevan

Differential Revision: https://phabricator.grailbio.com/D53226

fbshipit-source-id: 85c3615
Summary:
D53169 introduces a check for this error condition.  I'm exporting the
error string to make it less likely the check will unexpectedly stop
working.

Test Plan: Existing tests pass.

Reviewers: osakarya

Reviewed By: osakarya

Subscribers: cchang, smahadevan

Differential Revision: https://phabricator.grailbio.com/D53533

fbshipit-source-id: cf99570
Summary:
Change the automatically logged `caller` field from full file path to only file name.

The impetus for this change is that the caller root will be different depending on the system. For example, the tests will pass with `bazel test`, but fail with `go test`. We could possibly configure the full file path to be an option in the future.

Github Issue: #28

Test Plan: Update unit tests.

Reviewers: fdegiuli, msabherwal

Reviewed By: fdegiuli

Subscribers: jcharumilind, smahadevan

Differential Revision: https://phabricator.grailbio.com/D53636

fbshipit-source-id: 0a74d6d
Summary:
This diff refactors the logging system to support an interface. This gives more flexibility to users, specifically the ability to mock the logger.

With this refactor, we now support two logging flows. The first is the current flow with global, structless functions. The second is a flow that requires instantiation of the logger via `NewLogger()`.

Test Plan: Update unit tests and include tests for both flows.

Reviewers: msabherwal, fdegiuli

Reviewed By: msabherwal, fdegiuli

Subscribers: aeiser, jcharumilind, smahadevan

Differential Revision: https://phabricator.grailbio.com/D53655

fbshipit-source-id: 0a27a40
Summary:
Reduce dump-related logging noise by:

* Making the shortened CPU-profile message a `debug` level log, as it's generally not a very big deal.
* Eliminating the message about missing bigmachine profiles when no machines exist yet.  It's not an error for there to be no machines, so we no longer log about it.

Test Plan: Run `bazel run //go/src/grail.com/cmd/bigslice-demo -- fragments -bigslice-system=ec2:instance=m5.xlarge -bigslice-load-factor=1.0 -bigslice-parallelism=96`, and see quieter logs.

Reviewers: joshnewman

Reviewed By: joshnewman

Subscribers: smahadevan

Maniphest Tasks: T45889

Differential Revision: https://phabricator.grailbio.com/D53850

fbshipit-source-id: db620b4
After syncing with the GRAIL internal repo, there were build failures due to stale `go.mod` entries.  I have updated them with internal changes to fix those build failures and run `go mod tidy` to eliminate any unused entries.

Unit tests succeed.
josh-newman and others added 23 commits April 14, 2023 20:59
Co-authored-by: Jaran Charumilind <jcharumilind@grailbio.com>
Approved-by: Jaran Charumilind <jcharumilind@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/9319

fbshipit-source-id: 103ee9a
Approved-by: Josh Newman <joshnewman@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/10415

fbshipit-source-id: b3a09fd
Approved-by: Josh Newman <joshnewman@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/10759

fbshipit-source-id: 0f65f78
Co-authored-by: Jaran Charumilind <jcharumilind@grailbio.com>
Approved-by: Christopher Chang <cchang@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/10265

fbshipit-source-id: c8ba350
Approved-by: Josh Newman <joshnewman@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/11010

fbshipit-source-id: f56f178
…384)

Approved-by: Josh Newman <joshnewman@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/11384

fbshipit-source-id: 291035e
Approved-by: Josh Newman <joshnewman@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/11130

fbshipit-source-id: 47c400f
…l!11436)

Approved-by: Josh Newman <joshnewman@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/11436

fbshipit-source-id: bbcdcf7
…SE) (grailbio/grail!9318)

Co-authored-by: Jaran Charumilind <jcharumilind@grailbio.com>
Approved-by: Jaran Charumilind <jcharumilind@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/9318

fbshipit-source-id: 6ac0db7
Approved-by: Josh Newman <joshnewman@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/11579

fbshipit-source-id: 9b6607f
…ore (grailbio/grail!11597)

Co-authored-by: Christopher Chang <cchang@grailbio.com>
Co-authored-by: Jaran Charumilind <jcharumilind@grailbio.com>
Approved-by: Christopher Chang <cchang@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/11597

fbshipit-source-id: 2e45ecd
…bio/grail!11593)

Co-authored-by: Jaran Charumilind <jcharumilind@grailbio.com>
Approved-by: Christopher Chang <cchang@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/11593

fbshipit-source-id: 82e4569
…ail!12394)

Approved-by: Jaran Charumilind <jcharumilind@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/12394

fbshipit-source-id: b99fa14
Co-authored-by: Jaran Charumilind <jcharumilind@grailbio.com>
Approved-by: Jaran Charumilind <jcharumilind@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/11658

fbshipit-source-id: 37aea08
…for next migration step (grailbio/grail!12133)

Approved-by: Jaran Charumilind <jcharumilind@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/12133

fbshipit-source-id: b52e0fa
… generics migration (grailbio/grail!12449)

Co-authored-by: Jaran Charumilind <jcharumilind@grailbio.com>
Approved-by: Anirban Nandi <anandi@grailbio.com>
Approved-by: Jaran Charumilind <jcharumilind@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/12449

fbshipit-source-id: bd78ea7
…bio/grail!12658)

Approved-by: Josh Newman <joshnewman@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/12658

fbshipit-source-id: 3ff307a
Approved-by: Josh Newman <joshnewman@grailbio.com>
Approved-by: Alex Nguyen <anguyen@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/12488

fbshipit-source-id: b873666
…ilbio/grail!12653)

Approved-by: Josh Newman <joshnewman@grailbio.com>
Approved-by: Alex Nguyen <anguyen@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/12653

fbshipit-source-id: b3f166f
… security vulnerability (grailbio/grail!13748)

Approved-by: Alex Nguyen <anguyen@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/13748

fbshipit-source-id: 48ff10b
Approved-by: Jaran Charumilind <jcharumilind@grailbio.com>

GitLab URL: https://gitlab.com/grailbio/grail/-/merge_requests/14197

fbshipit-source-id: 447558d
Bumps [github.com/gin-gonic/gin](https://github.com/gin-gonic/gin) from 1.6.3 to 1.9.0.
- [Release notes](https://github.com/gin-gonic/gin/releases)
- [Changelog](https://github.com/gin-gonic/gin/blob/master/CHANGELOG.md)
- [Commits](gin-gonic/gin@v1.6.3...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/gin-gonic/gin
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Author

dependabot bot commented on behalf of github Mar 7, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/gin-gonic/gin-1.9.0 branch March 7, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.