Create implicit alias for subquery instead of using alias this_ #172

puneetbehl · 2020-02-03T13:23:08Z

Added method getHibernateDetachedCriteria(AbstractHibernateQuery query, QueryableCriteria<?> queryableCriteria, String alias) to accept alias as an argument in HibernateCriteriaBuilder.
Updated Query.Exists.class criterionAdaptor to explicitly create and pass the new alias to the detachedCriteria, only if the subquery.alias is null.
Added method protected org.hibernate.criterion.DetachedCriteria toHibernateDetachedCriteria(AbstractHibernateQuery query, QueryableCriteria<?> queryableCriteria, String alias) to the AbstractHibernateCriterionAdapter with default implementation
Overidde toHibernateDetachedCriteria(AbstractHibernateQuery query, QueryableCriteria<?> queryableCriteria, String alias) in HibernateCriteriaAdaptor to pass the alias.

Fixes #171

Fixed incorrect criteria.

to avoid multiple conflicting this_ aliases.

puneetbehl added 3 commits February 3, 2020 15:48

apache/grails-data-mapping#1267 Update test

8310312

Fixed incorrect criteria.

#171 Test incorrect result with sub-query due to this_ alias conflict

47b2bf0

#171 Implicitly create alias for inner sub-query

675e229

to avoid multiple conflicting this_ aliases.

puneetbehl requested review from graemerocher and jameskleeh February 3, 2020 13:23

jameskleeh merged commit 8722a83 into master Feb 3, 2020

jameskleeh deleted the implicitSubqueryAlias branch February 3, 2020 20:08

Provide feedback