Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Node with Deno in Deno code block #421

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Replace Node with Deno in Deno code block #421

merged 7 commits into from
Jun 22, 2022

Conversation

rojvv
Copy link
Member

@rojvv rojvv commented Jun 5, 2022

No description provided.

@rojvv rojvv mentioned this pull request Jun 5, 2022
58 tasks
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

@github-actions github-actions bot temporarily deployed to pull request June 5, 2022 14:33 Inactive
site/docs/advanced/reliability.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 5, 2022 15:32 Inactive
Copy link
Contributor

@quadratz quadratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rojvv rojvv added the ready for translation Translator intervention is required. label Jun 5, 2022
@habemuscode habemuscode added the 🇪🇸 ES Modifies or is related to the Spanish translations. label Jun 6, 2022
@github-actions github-actions bot temporarily deployed to pull request June 6, 2022 13:34 Inactive
site/docs/es/plugins/runner.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 9, 2022 16:12 Inactive
@KnorpelSenf
Copy link
Member

@roj1512 What is the purpose of this PQ? I do not understand how making things less explicit will make it more clear.

@rojvv
Copy link
Member Author

rojvv commented Jun 14, 2022

It was originally to remove the term "Node process" in the Deno code block.

@KnorpelSenf
Copy link
Member

It was originally to remove the term "Node process" in the Deno code block.

I would prefer if we could simply fix that oversight and refer to the Deno process.

@rojvv rojvv changed the title Mention the rutime process implicitly Replace Node with Deno in Deno code block Jun 14, 2022
@github-actions github-actions bot temporarily deployed to pull request June 14, 2022 19:37 Inactive
@rojvv rojvv removed the 🇪🇸 ES Modifies or is related to the Spanish translations. label Jun 14, 2022
@rojvv rojvv requested a review from KnorpelSenf June 14, 2022 19:39
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot temporarily deployed to pull request June 14, 2022 19:40 Inactive
@WingLim WingLim added the 🇨🇳 ZH Modifies or is related to the Chinese translations. label Jun 15, 2022
@github-actions github-actions bot temporarily deployed to pull request June 15, 2022 05:49 Inactive
@KnorpelSenf
Copy link
Member

@habemuscode not sure if you followed along, this translation needs to be re-done :)

@github-actions github-actions bot temporarily deployed to pull request June 22, 2022 18:36 Inactive
@habemuscode habemuscode added the 🇪🇸 ES Modifies or is related to the Spanish translations. label Jun 22, 2022
@rojvv rojvv merged commit 03faffb into main Jun 22, 2022
@rojvv rojvv deleted the graceful-shutdown branch June 22, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🇨🇳 ZH Modifies or is related to the Chinese translations. 🇪🇸 ES Modifies or is related to the Spanish translations. ready for translation Translator intervention is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants