Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Starting react-scripts dev server in CI mode so it runs in docker-compose #61

Merged

Conversation

arel
Copy link
Contributor

@arel arel commented Apr 6, 2020

This allows the development server that comes with create-react-app to run in docker-compose where no interactive shell is available. Otherwise, the dev server exits immediately.

This addresses issue #60.

To test, pull the latest docker images, or start from a clean slate, and try:

docker-compose up

with and without the CI=true environment variable set.

This allows the development server that comes with
create-react-app to start up in docker-compose where
no interactive shell is available. Otherwise,
the dev server exits immediately.
@johnymontana
Copy link
Contributor

Thanks @arel!

@johnymontana johnymontana merged commit 07c4a9a into grand-stack:master Apr 6, 2020
@arel arel deleted the fix-docker-compose-react-startup branch April 6, 2020 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants