Skip to content

Conversation

thecharlieblake
Copy link
Contributor

@thecharlieblake thecharlieblake commented May 4, 2023

pip install git+https://github.com/graphcore-research/unit-scaling.git

currently fails with:

× Encountered error while trying to install package.
╰─> poptorch-experimental-addons

I think because it requires our SDK to be available - which we clearly don't want! Easiest solution for now is just to remove the poptorch/pea stuff in the codebase. It's only a few lines of code. We can find a way to add this back in at a later date and fix the issue properly if needs be.

@thecharlieblake thecharlieblake requested a review from DouglasOrr May 4, 2023 10:20
Copy link
Collaborator

@DouglasOrr DouglasOrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be enough just to move poptorch-experimental-addons to a requirements-ipu.txt file? You already have the try... except that should make the code itself work without poptorch/pea (I think?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants