fix: addToDelegationPool token transfer (OZ C-01 and C-02) #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maikol
changed the title
fix: addToDelegationPool token transfer (OZ C-01 and C-02)
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
tmigone
requested changes
Aug 13, 2024
| @@ -278,6 +278,8 @@ contract HorizonStaking is HorizonStakingBase, IHorizonStakingMain { | |||
| uint256 tokens | |||
| ) external override notPaused { | |||
| require(tokens != 0, HorizonStakingInvalidZeroTokens()); | |||
| require(msg.sender == verifier || msg.sender == address(_graphPayments()), HorizonStakingInvalidDelegationPoolSender(msg.sender)); | |||
There was a problem hiding this comment.
I know OZ suggested this, but I'd argue we don't need it:
- We would be limiting potential use cases we don't know about
- Documentation already mentions that delegators SHOULD NOT use this function and it's not like we will be creating client side apps to facilitate calling it.
There was a problem hiding this comment.
I think this makes sense but worth discussing with OZ just in case, it could increase the risk of rounding attacks etc.
(If we do go ahead as it is, let's rename the PR without the "access control" part)
There was a problem hiding this comment.
I've renamed and will let OZ know so they can give their feedback.
tmigone
approved these changes
Aug 13, 2024
Maikol
changed the title
tmigone
force-pushed
the
mde/pr988-fix-oz-c-01
branch
from
54b150c
to
f4f9bad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.