docs: graphql validations guide #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saihaj
commented
Feb 16, 2023
dotansimha
approved these changes
Feb 17, 2023
azf20
previously requested changes
Feb 27, 2023
| title: GraphQL Validations migration guide | ||
| --- | ||
|
|
||
| Soon `graph-node` will support 100% coverage of the [GraphQL Validations specification](https://spec.graphql.org/June2018/#sec-Validation). |
There was a problem hiding this comment.
We should align on timing and be clear in this document what the expectations are for:
- Hosted Service
- A release on the network
saihaj
force-pushed
the
saihaj/282-add-graphql-validation-guide-from-the-guild
branch
from
e6f0a9e to
fffd4d1
Compare
saihaj
force-pushed
the
saihaj/282-add-graphql-validation-guide-from-the-guild
branch
from
fffd4d1 to
c75a526
Compare
saihaj
force-pushed
the
saihaj/282-add-graphql-validation-guide-from-the-guild
branch
from
c75a526 to
2858f04
Compare
saihaj
requested review from
azf20,
dotansimha,
michaelanegus and
MichaelMacaulay
dotansimha
approved these changes
Mar 29, 2023
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.42 MB (🟡 +45 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Page Added
The following page was added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load | % of Budget (350 KB) |
|---|---|---|---|
/en/release-notes/graphql-validations-migration-guide |
9.11 KB |
1.42 MB | 416.80% |
Web3Slimchance
requested changes
Mar 30, 2023
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
website/pages/en/release-notes/graphql-validations-migration-guide.mdx
Outdated
Show resolved
Hide resolved
MichaelMacaulay
approved these changes
Mar 30, 2023
saihaj
deleted the
saihaj/282-add-graphql-validation-guide-from-the-guild
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #282