-
Notifications
You must be signed in to change notification settings - Fork 155
Multichain ready #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichain ready #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! 🙌
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Thank you so much for working on this - 🔥
Subgraphs using IPFS are currently not eligible for Indexing Rewards
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this. See comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you - very much. Left a couple more comments 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thank you Michael 🙌
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 Nineteen Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Outstanding questions:
There are certain constraints on The Graph Network, in terms of feature and network support. Currently only mainnet Ethereum subgraphs will earn indexing rewards, and subgraphs which fetch data from IPFS are also not eligible.
Ethereum-compliant JSON-RPC
to index a network.