chore: move to monorepo #296
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
|
we can ignore this comment since right now on |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Dimitri POSTOLOV <en3m@ya.ru>
| - packages/* | ||
| - website |
There was a problem hiding this comment.
Why is website not in packages? (I appreciate that it's not too nested/buried, but I guess my question is why wouldn't the other packages also be directly in the root?)
There was a problem hiding this comment.
we can put it in packages 👍
There was a problem hiding this comment.
I just followed a common structure we keep in our projects. This way packages only refers to only standalone packages and website is a service that gets deployed so it uses packages.
There was a problem hiding this comment.
Got it, I guess that makes sense if the packages don't get deployed and are all used by the main package!
This comment was marked as resolved.
This comment was marked as resolved.
package.json
Outdated
| "@types/react": "^17.0.53", | ||
| "@types/react-dom": "^17.0.18", | ||
| "acorn": "^8.8.2", | ||
| "acorn-jsx": "^5.3.2", | ||
| "eslint": "^8.34.0", | ||
| "fast-xml-parser": "^4.1.2", | ||
| "husky": "^8.0.3", | ||
| "lint-staged": "^13.1.1", | ||
| "path": "^0.12.7", |
There was a problem hiding this comment.
@benface any thoughts why we need this package?
There was a problem hiding this comment.
We use it, but we should be able to just use the built-in node:path instead. Good catch.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Move to a monorepo structure. All the docs live in
website/*so in future we can addpackages/*so we can maintain shared configs, components and themes for Nextra.