Skip to content

Conversation

MichaelMacaulay
Copy link
Contributor

  • "Migrating" to the network is now "Upgrading" to the network
  • Upgrade (previously used to refer to releasing a new version of a subgraph) is now "updating a subgraph"
  • Migration grants are now "Network Grants"

Other misc. changes:

  • Updated URL of migration cookbook (hopefully with a functional redirect)
  • Added definitions to the glossary

@MichaelMacaulay MichaelMacaulay requested a review from a team as a code owner July 25, 2023 18:19
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 650.11 KB (🟡 +56 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/en/cookbook/upgrading-a-subgraph 11.81 KB 661.92 KB 189.12%

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/en/arbitrum/l2-transfer-tools-guide 11.51 KB 661.61 KB 189.03% (+/- <0.01%)
/en/deploying/hosted-service 6.48 KB 656.58 KB 187.60% (+/- <0.01%)
/en/developing/creating-a-subgraph 25.3 KB 675.41 KB 192.97% (+/- <0.01%)
/en/developing/developer-faqs 9.83 KB 659.94 KB 188.55% (🟡 +0.01%)
/en/glossary 7.92 KB 658.03 KB 188.01% (🟡 +0.04%)
/en/mips-faqs 8.83 KB 658.94 KB 188.27% (+/- <0.01%)
/en/network-transition-faq 13.65 KB 663.76 KB 189.65% (+/- <0.01%)
/en/network/benefits 7.04 KB 657.15 KB 187.76% (🟡 +0.01%)
/en/network/curating 10.14 KB 660.24 KB 188.64% (+/- <0.01%)
/en/network/developing 6.89 KB 657 KB 187.71% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

MichaelMacaulay and others added 6 commits July 31, 2023 13:32
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Co-authored-by: Benoît Rouleau <benoit.rouleau@icloud.com>
Migrating = curation shares moving to latest version of subgraph
Copy link
Contributor

@azf20 azf20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left some comments


If you’re a subgraph developer, you can upgrade a new version of your subgraph to the Studio using the CLI. It’ll be private at that point, but if you’re happy with it, you can publish to the decentralized Graph Explorer. This will create a new version of your subgraph that Curators can start signaling on.
If you’re a subgraph developer, you can update a new version of your subgraph to the Subgraph Studio using the CLI. It’ll be private at that point, but if you’re happy with it, you can publish to the decentralized Graph Explorer. This will create a new version of your subgraph that Curators can start signaling on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "deploy" rather than "update"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think update was right in the title, I was referring to the body ("If you’re a subgraph developer, you can update a new version of your subgraph")


Yes, it is 1% of curation signaled. The 1% is split evenly between Curators (0.5%) and subgraph developers (0.5%). So, for every 10K GRT signaled, it costs subgraph developers 50 GRT to upgrade.
Yes, it is 1% of curation signaled. The 1% is split evenly between Curators (0.5%) and subgraph developers (0.5%). So, for every 10K GRT signaled, it costs subgraph developers 50 GRT to update.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth verifying these numbers cc @abarmat


Migrating your curation shares to a new subgraph version incurs a curation tax of 1%. Curators can choose to subscribe to the newest version of a subgraph. When curator shares get auto-migrated to a new version, Curators will also pay half curation tax, ie. 0.5%, because upgrading subgraphs is an on-chain action that costs gas.
Migrating your curation shares to a new subgraph version incurs a curation tax of 1%. Curators can choose to subscribe to the newest version of a subgraph. When curator shares get auto-migrated to a new version, Curators will also pay half curation tax, ie. 0.5%, because updating subgraphs is an on-chain action that costs gas.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because updating subgraphs is an on-chain action that costs gas.

I don't know if this is accurate? cc @abarmat


If you’re a subgraph developer, you can upgrade a new version of your subgraph to the Studio using the CLI. It’ll be private at that point, but if you’re happy with it, you can publish to the decentralized Graph Explorer. This will create a new version of your subgraph that Curators can start signaling on.
If you’re a subgraph developer, you can update a new version of your subgraph to the Subgraph Studio using the CLI. It’ll be private at that point, but if you’re happy with it, you can publish to the decentralized Graph Explorer. This will create a new version of your subgraph that Curators can start signaling on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think update was right in the title, I was referring to the body ("If you’re a subgraph developer, you can update a new version of your subgraph")

@MichaelMacaulay MichaelMacaulay merged commit 7120c45 into main Aug 3, 2023
@MichaelMacaulay MichaelMacaulay deleted the Migrate-to-Upgrade branch August 3, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants