fix (offset - 1) pagination #584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaMachina
commented
Jan 16, 2024
| network: 'The Graph Network', | ||
| sunrise: 'Sunrise FAQ', | ||
| billing: '', | ||
| 'network-transition-faq': '', |
There was a problem hiding this comment.
this hidden route produced offset - 1 issue since, I used flatDirectories list instead of flatDocsDirectories
because in original nextra-theme-docs were props naming confusing
https://github.com/shuding/nextra/blob/2f001d897f2109b24600f66fe2009e5f788b980c/packages/nextra-theme-docs/src/components/nav-links.tsx#L22
https://github.com/shuding/nextra/blob/2f001d897f2109b24600f66fe2009e5f788b980c/packages/nextra-theme-docs/src/index.tsx#L220
dimaMachina
commented
Jan 16, 2024
Comment on lines
+70
to
+72
| - Manifest (`subgraph.yaml`) - The manifest defines what datasources your subgraphs will index. | ||
| - Schema (`schema.graphql`) - The GraphQL schema defines what data you wish to retrieve from the subgraph. | ||
| - AssemblyScript Mappings (`mapping.ts`) - This is the code that translates data from your datasources to the entities defined in the schema. |
There was a problem hiding this comment.
just better to use inline code blocks for filenames
saihaj
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #409