Skip to content

remove cosmos #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

remove cosmos #882

merged 2 commits into from
Feb 18, 2025

Conversation

yash251
Copy link
Member

@yash251 yash251 commented Feb 18, 2025

No description provided.

@yash251 yash251 requested a review from a team as a code owner February 18, 2025 18:36
@yash251
Copy link
Member Author

yash251 commented Feb 18, 2025

cc @benface @idalithb

benface
benface approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@benface benface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@benface
Copy link
Contributor

benface commented Feb 18, 2025

Oh @yash251, I see there's a formatting issue which makes the format CI check fail. We use Prettier; I recommend installing the VS Code Prettier extension and enabling "Format on save" to not have to think about it. But I will run pnpm check:fix in your branch, it should fix it. Thank you!

@idalithb idalithb merged commit d5de9f3 into main Feb 18, 2025
4 checks passed
@idalithb idalithb deleted the yash251/remove-cosmos branch February 18, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benface benface benface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash251 @benface @idalithb