Skip to content

Conversation

Jannis
Copy link
Contributor

@Jannis Jannis commented May 9, 2019

If --abi is provided and the user is guided through the init form, we want to skip downloading the ABI from Etherscan to a) not confuse the user and b) to not override the user-provided ABI.

Reported on Discord earlier today.

@Jannis Jannis added bug Something isn't working developer experience area/cli labels May 9, 2019
@Jannis Jannis added this to the Q2 2019 milestone May 9, 2019
@Jannis Jannis requested a review from a team May 9, 2019 23:02
@Jannis Jannis self-assigned this May 9, 2019
@ghost ghost added the pending review label May 9, 2019
@Jannis Jannis merged commit 805b7e4 into master May 10, 2019
@ghost ghost removed the pending review label May 10, 2019
@Jannis Jannis deleted the jannis/skip-etherscan-if-abi-is-provided branch May 16, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants