Top level data source templates #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannis
suggested changes
Aug 13, 2019
|
@Jannis comments addressed. |
fordN
approved these changes
Aug 14, 2019
Jannis
approved these changes
Aug 15, 2019
leoyvens
force-pushed
the
leo/top-level-templates
branch
from
620c0af to
cd5740d
Compare
leoyvens
force-pushed
the
leo/top-level-templates
branch
from
cd5740d to
f29d933
Compare
|
Rebased, and fixed a bug with the output directory of template mappings. @Jannis could you review again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See graphprotocol/graph-node#1023. The old format is immediately unsupported, but we print a helpful error message.
One change that was not in the plan is the path to the codegen'ed files. The template classes now all go in
generated/templates.tsand their ABIs ingenerated/templates/<template_name>/<abi_name>.ts.This also does a migration to bump the spec version to 0.0.2, since this is a breaking change.