Expose reverts to mappings #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
graph-ts PR needs to be merged for tests to pass. |
Jannis
approved these changes
Sep 2, 2019
src/codegen/abi.js
Outdated
There was a problem hiding this comment.
This section might be easier to read if there was just one top-level isTry-based conditional rather than a few spread across the nested logic.
|
@Jannis you're right, we can collapse the conditionals, thanks! |
leoyvens
force-pushed
the
leo/expose-reverts-to-mappings
branch
from
4f53951 to
72aab67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of graphprotocol/graph-node#1120.
In addition to the contract calls we already generate, we'll generate a version prefixed with
try_that returns aCallResult<T>allowing the mapping to handle failures. See graph-ts PR graphprotocol/graph-ts#74.