Migration fixes, IPFS upload optimization #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of the migrations only replaced the first occurrence, which is obviously not correct.
This caused migrations to run even when `--skip-migrations` was passed to commands on the command-line.
This speeds up uploading subgraphs that reuse the same mappings and ABIs across many data sources.
|
I'm going to take the liberty and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of things:
Existing
apiVersionmigrations are updated to replace allapiVersionoccurrences. Before, only the first would be replaced.--skip-migrationsis now properly passed on to the compiler. For some time, it wasn't.These fixes are necessary for daostack/subgraph#318 to work.
Another change made in this PR is that during a
graph build --ipfs ...andgraph deploy, files are only uploaded to IPFS once. Any repeated upload attempts simply pick the IPFS hash from a short-lived cache. This speeds up build/deploy for subgraphs that reuse ABIs or mappings across many data sources (like DAOstack).