Make types non-nullable by default #807
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a discrepancy between how the graphql types are generated during scaffolding and how they are read during code generation.
If I have an abi like this https://github.com/nevermined-io/contracts/blob/5b8680b3c581ec50877ed8451c623c8480ac000d/artifacts/AccessProofCondition.mumbai.json#L3-L52 and using the cli to run
graph init
with--index-events
it will generate the following schema.Now during code generation when the
uint256[]
types are converted from graphql it complains that lists cannot have nullable types.Changing a default is probably not the best idea but I'm glad to help if someone points me in the right direction