Skip to content

fix: canonicalize identity before encrypting #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: canonicalize identity before encrypting #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/hypergraph/src/identity/identity-encryption.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { sha256 } from '@noble/hashes/sha256';
import type { Hex } from 'viem';
import { verifyMessage } from 'viem';

import { bytesToHex, hexToBytes } from '../utils/index.js';
import { bytesToHex, canonicalize, hexToBytes } from '../utils/index.js';
import type { IdentityKeys, Signer } from './types.js';

// Adapted from the XMTP approach to encrypt keys
Expand Down Expand Up @@ -36,7 +36,7 @@ const encrypt = (msg: Uint8Array, secret: Uint8Array): string => {
const ciphertext = aes.encrypt(msg);

// TODO: Use Effect Schema and better serialization?
const ciphertextJson = JSON.stringify({
const ciphertextJson = canonicalize({
aes256GcmHkdfSha256: {
payload: bytesToHex(ciphertext),
hkdfSalt: bytesToHex(hkdfSalt),
Expand Down
Loading