fixed loginWithKeys function and moved it to core + add tests #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikgraf
force-pushed
the
ng/move-login-with-keys
branch
from
68d8a05 to
202a617
Compare
nikgraf
changed the title
pcarranzav
approved these changes
Feb 4, 2025
| } | ||
|
|
||
| const account = privateKeyToAccount(keys.signaturePrivateKey as Hex); | ||
| const sessionNonce = await getSessionNonce(accountId, syncServerUri); |
There was a problem hiding this comment.
Good catch here, I hadn't realized we were using the wrong account ID
| if (url.toString() === 'http://localhost:3000/whoami') { | ||
| return Promise.resolve({ | ||
| status: 200, | ||
| text: () => Promise.resolve(accountId), |
There was a problem hiding this comment.
Isn't this actually testing with a valid existing token? Shouldn't this return a different account ID or an error to test the case of an invalid token? (Unless I'm missing something)
There was a problem hiding this comment.
spot on! fixed the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tested it in the example app by removing the sessionToken from the localstorage.