Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Sep 14, 2025

No description provided.

@nikgraf nikgraf requested a review from Copilot September 14, 2025 15:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Dockerfile to deploy a new server by changing all package filter references from "server" to "server-new". The change affects the build process for database migrations, Prisma client generation, server building, and deployment.

  • Updates all pnpm filter commands to target "server-new" instead of "server"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 29 to +30
# TODO: This initalizes the database. But we should probably remove this later.
# pnpm --filter server prisma migrate reset --force && \
# pnpm --filter server-new prisma migrate reset --force && \
Copy link

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The TODO comment mentions removing the database initialization later, but changing from 'server' to 'server-new' while keeping this as a commented line may cause confusion. Consider updating the TODO to reflect that this applies to the new server package, or remove the outdated comment entirely.

Copilot uses AI. Check for mistakes.

@nikgraf nikgraf merged commit f021bf1 into main Sep 14, 2025
6 checks passed
@nikgraf nikgraf deleted the ng/deploy-new-server branch September 14, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant